code audit fixes: require_once, issue flow, role guards
This commit is contained in:
@@ -194,6 +194,7 @@
|
||||
var current_tab = <?php echo json_encode($_GET['tab'] ?? 'invoice'); ?>;
|
||||
var all_invoices = [];
|
||||
var formula_map = {};
|
||||
const can_delete = ['admin', 'owner'].includes(user_role);
|
||||
|
||||
function is_invoice_overdue(status, due_date) {
|
||||
if (String(status) !== '1' || !due_date) return false;
|
||||
@@ -362,9 +363,7 @@
|
||||
<a href="javascript:;" title="View GL Entry" class="me-2" onclick="show_gl_modal('invoice',${inv.id})">
|
||||
<i class="ti ti-book fs-5 text-secondary"></i>
|
||||
</a>
|
||||
<a href="javascript:;" title="Delete" class="link-danger" onclick="delete_invoice(${inv.id},'${escape_html(inv.invoice_number)}')">
|
||||
<i class="ti ti-trash fs-5"></i>
|
||||
</a>
|
||||
${can_delete ? `<a href="javascript:;" title="Delete" class="link-danger" onclick="delete_invoice(${inv.id},'${escape_html(inv.invoice_number)}')"><i class="ti ti-trash fs-5"></i></a>` : ''}
|
||||
</td>
|
||||
</tr>`;
|
||||
});
|
||||
@@ -410,9 +409,7 @@
|
||||
<a href="javascript:;" title="View GL Entry" class="me-2" onclick="show_gl_modal('credit_note',${cn.id})">
|
||||
<i class="ti ti-book fs-5 text-secondary"></i>
|
||||
</a>
|
||||
<a href="javascript:;" title="Delete" class="link-danger" onclick="delete_invoice(${cn.id},'${escape_html(cn.invoice_number)}')">
|
||||
<i class="ti ti-trash fs-5"></i>
|
||||
</a>
|
||||
${can_delete ? `<a href="javascript:;" title="Delete" class="link-danger" onclick="delete_invoice(${cn.id},'${escape_html(cn.invoice_number)}')"><i class="ti ti-trash fs-5"></i></a>` : ''}
|
||||
</td>
|
||||
</tr>`;
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user