From 9a8998796c1bae889309dc84cfa2a630543a854c Mon Sep 17 00:00:00 2001
From: Thanakorn <thanakorn.inbox@gmail.com>
Date: Sat, 19 Sep 2026 06:33:45 +0700
Subject: [PATCH] Redirect finance detail pages to their list when opened
 without an id

---
 app/finance/manage_payment.php         | 10 +++++++++-
 app/finance/manage_payment_billing.php | 10 +++++++++-
 app/finance/manage_receipt.php         | 10 +++++++++-
 app/finance/manage_receipt_billing.php | 10 +++++++++-
 4 files changed, 36 insertions(+), 4 deletions(-)

diff --git a/app/finance/manage_payment.php b/app/finance/manage_payment.php
index cbb3727..b51a310 100644
--- a/app/finance/manage_payment.php
+++ b/app/finance/manage_payment.php
@@ -1,9 +1,17 @@
 <?php
   session_start();
   require '../config.php';
-  require '../include_header.php';
 
+  // A detail-only page: payments are created from the Payments list, so with no
+  // id there is nothing to show. Send the user there instead of rendering an
+  // empty page that alerts "Payment id is required."
   $payment_id = (int)($_GET['id'] ?? 0);
+  if (!$payment_id) {
+    header('Location: ' . $server_url . 'finance/payment.php');
+    exit;
+  }
+
+  require '../include_header.php';
 ?>
 
 <body>
diff --git a/app/finance/manage_payment_billing.php b/app/finance/manage_payment_billing.php
index 1cb4631..55958a3 100644
--- a/app/finance/manage_payment_billing.php
+++ b/app/finance/manage_payment_billing.php
@@ -1,9 +1,17 @@
 <?php
   session_start();
   require '../config.php';
-  require '../include_header.php';
 
+  // A detail-only page: payment billings are created from their list, so with
+  // no id there is nothing to show. Send the user there instead of rendering an
+  // empty page that alerts "Payment billing id is required."
   $billing_id = (int)($_GET['id'] ?? 0);
+  if (!$billing_id) {
+    header('Location: ' . $server_url . 'finance/payment_billing.php');
+    exit;
+  }
+
+  require '../include_header.php';
 ?>
 
 <body>
diff --git a/app/finance/manage_receipt.php b/app/finance/manage_receipt.php
index f357a7a..68945d1 100644
--- a/app/finance/manage_receipt.php
+++ b/app/finance/manage_receipt.php
@@ -1,9 +1,17 @@
 <?php
   session_start();
   require '../config.php';
-  require '../include_header.php';
 
+  // A detail-only page: receipts are created from the Receipts list, so with no
+  // id there is nothing to show. Send the user there instead of rendering an
+  // empty page that alerts "Receipt id is required."
   $receipt_id = (int)($_GET['id'] ?? 0);
+  if (!$receipt_id) {
+    header('Location: ' . $server_url . 'finance/receipt.php');
+    exit;
+  }
+
+  require '../include_header.php';
 ?>
 
 <body>
diff --git a/app/finance/manage_receipt_billing.php b/app/finance/manage_receipt_billing.php
index 19beb16..f8d94b0 100644
--- a/app/finance/manage_receipt_billing.php
+++ b/app/finance/manage_receipt_billing.php
@@ -1,9 +1,17 @@
 <?php
   session_start();
   require '../config.php';
-  require '../include_header.php';
 
+  // A detail-only page: receipt billings are created from their list, so with
+  // no id there is nothing to show. Send the user there instead of rendering an
+  // empty page that alerts "Receipt billing id is required."
   $billing_id = (int)($_GET['id'] ?? 0);
+  if (!$billing_id) {
+    header('Location: ' . $server_url . 'finance/receipt_billing.php');
+    exit;
+  }
+
+  require '../include_header.php';
 ?>
 
 <body>